Fix SeqManager::GetMaxOutput()#1840
Merged
Merged
Conversation
# Details - Fixes #1839 - Make `SeqManager::GetMaxOutput()` account for `initialOutput`. - `GetMaxOutput()` returned the internal offset-less max output, while the sequence numbers it was compared against (in `Consumer.cpp`) carry the `initialOutput` offset. Since `initialOutput` is always non-zero, the check at `Consumer.cpp` never matched, leaving `lastSentPacketHasMarker` stuck at `false` and skewing the simulcast sync seq value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
SeqManager::GetMaxOutput()account forinitialOutput.GetMaxOutput()returned the internal offset-less max output, while the sequence numbers it was compared against (inConsumer.cpp) carry theinitialOutputoffset. SinceinitialOutputis always non-zero, the check atConsumer.cppnever matched, leavinglastSentPacketHasMarkerstuck atfalseand skewing the simulcast sync seq value.